Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Fix lodash import #589

Merged
merged 1 commit into from
Jan 9, 2023
Merged

(fix) Fix lodash import #589

merged 1 commit into from
Jan 9, 2023

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jan 4, 2023 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Fixes a lodash import, ensuring isEqual gets imported from lodash-es instead of lodash, as is the case with other usages of the library in this package. The corollary of this change is that the overall bundle size gets reduced by around 39 kB (2%).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Size Change: -38.3 kB (-2%)

Total Size: 2.05 MB

Filename Size Change
packages/apps/esm-devtools-app/dist/889.js 109 kB -4.36 kB (-4%)
packages/apps/esm-implementer-tools-app/dist/889.js 109 kB -4.35 kB (-4%)
packages/apps/esm-login-app/dist/889.js 109 kB -4.36 kB (-4%)
packages/apps/esm-offline-tools-app/dist/889.js 109 kB -4.36 kB (-4%)
packages/apps/esm-primary-navigation-app/dist/889.js 109 kB -4.36 kB (-4%)
packages/framework/esm-framework/dist/openmrs-esm-framework.js 202 kB -9 kB (-4%)
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 18.3 kB -4.23 kB (-19%) 👏
packages/shell/esm-app-shell/dist/openmrs.js 350 kB -3.25 kB (-1%)
ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/733.js 3.55 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/988.js 363 B 0 B
packages/apps/esm-devtools-app/dist/main.js 2.87 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.04 kB 0 B
packages/apps/esm-implementer-tools-app/dist/102.js 2.76 kB 0 B
packages/apps/esm-implementer-tools-app/dist/146.js 6.71 kB 0 B
packages/apps/esm-implementer-tools-app/dist/190.js 61.1 kB 0 B
packages/apps/esm-implementer-tools-app/dist/246.js 1.14 kB 0 B
packages/apps/esm-implementer-tools-app/dist/280.js 3.46 kB 0 B
packages/apps/esm-implementer-tools-app/dist/284.js 1.46 kB 0 B
packages/apps/esm-implementer-tools-app/dist/319.js 454 B 0 B
packages/apps/esm-implementer-tools-app/dist/406.js 11.6 kB 0 B
packages/apps/esm-implementer-tools-app/dist/519.js 2.36 kB 0 B
packages/apps/esm-implementer-tools-app/dist/531.js 1.49 kB 0 B
packages/apps/esm-implementer-tools-app/dist/542.js 2.04 kB 0 B
packages/apps/esm-implementer-tools-app/dist/574.js 428 B 0 B
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB 0 B
packages/apps/esm-implementer-tools-app/dist/626.js 5.06 kB 0 B
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/769.js 11.8 kB 0 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 3.94 kB 0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.26 kB 0 B
packages/apps/esm-login-app/dist/236.js 268 B 0 B
packages/apps/esm-login-app/dist/240.js 359 B 0 B
packages/apps/esm-login-app/dist/272.js 260 B 0 B
packages/apps/esm-login-app/dist/319.js 356 B 0 B
packages/apps/esm-login-app/dist/336.js 224 B 0 B
packages/apps/esm-login-app/dist/390.js 597 B 0 B
packages/apps/esm-login-app/dist/406.js 1.13 kB 0 B
packages/apps/esm-login-app/dist/420.js 1.61 kB 0 B
packages/apps/esm-login-app/dist/50.js 6.18 kB 0 B
packages/apps/esm-login-app/dist/539.js 294 B 0 B
packages/apps/esm-login-app/dist/574.js 443 B 0 B
packages/apps/esm-login-app/dist/581.js 23.9 kB 0 B
packages/apps/esm-login-app/dist/607.js 3.92 kB 0 B
packages/apps/esm-login-app/dist/611.js 720 B 0 B
packages/apps/esm-login-app/dist/644.js 299 B 0 B
packages/apps/esm-login-app/dist/673.js 278 B 0 B
packages/apps/esm-login-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-login-app/dist/757.js 293 B 0 B
packages/apps/esm-login-app/dist/759.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/897.js 5.18 kB 0 B
packages/apps/esm-login-app/dist/925.js 6.66 kB 0 B
packages/apps/esm-login-app/dist/951.js 1.31 kB 0 B
packages/apps/esm-login-app/dist/main.js 3.29 kB 0 B
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.18 kB 0 B
packages/apps/esm-offline-tools-app/dist/106.js 7.43 kB 0 B
packages/apps/esm-offline-tools-app/dist/126.js 1.35 kB 0 B
packages/apps/esm-offline-tools-app/dist/259.js 2.76 kB 0 B
packages/apps/esm-offline-tools-app/dist/290.js 434 B 0 B
packages/apps/esm-offline-tools-app/dist/316.js 3.56 kB 0 B
packages/apps/esm-offline-tools-app/dist/373.js 2.83 kB 0 B
packages/apps/esm-offline-tools-app/dist/386.js 51.2 kB 0 B
packages/apps/esm-offline-tools-app/dist/391.js 299 B 0 B
packages/apps/esm-offline-tools-app/dist/412.js 3.85 kB 0 B
packages/apps/esm-offline-tools-app/dist/456.js 1.89 kB 0 B
packages/apps/esm-offline-tools-app/dist/518.js 2.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/541.js 379 B 0 B
packages/apps/esm-offline-tools-app/dist/574.js 996 B 0 B
packages/apps/esm-offline-tools-app/dist/58.js 1.99 kB 0 B
packages/apps/esm-offline-tools-app/dist/733.js 285 B 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/740.js 4.57 kB 0 B
packages/apps/esm-offline-tools-app/dist/759.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/795.js 5.55 kB 0 B
packages/apps/esm-offline-tools-app/dist/925.js 6.66 kB 0 B
packages/apps/esm-offline-tools-app/dist/967.js 489 B 0 B
packages/apps/esm-offline-tools-app/dist/996.js 5.88 kB 0 B
packages/apps/esm-offline-tools-app/dist/main.js 52.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.26 kB 0 B
packages/apps/esm-primary-navigation-app/dist/146.js 6.72 kB 0 B
packages/apps/esm-primary-navigation-app/dist/216.js 544 B 0 B
packages/apps/esm-primary-navigation-app/dist/34.js 3.03 kB 0 B
packages/apps/esm-primary-navigation-app/dist/414.js 461 B 0 B
packages/apps/esm-primary-navigation-app/dist/473.js 1.16 kB 0 B
packages/apps/esm-primary-navigation-app/dist/483.js 11.4 kB 0 B
packages/apps/esm-primary-navigation-app/dist/574.js 178 B 0 B
packages/apps/esm-primary-navigation-app/dist/656.js 5.51 kB 0 B
packages/apps/esm-primary-navigation-app/dist/710.js 6.28 kB 0 B
packages/apps/esm-primary-navigation-app/dist/723.js 4.52 kB 0 B
packages/apps/esm-primary-navigation-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-primary-navigation-app/dist/787.js 9.38 kB 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/98.js 2.2 kB 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 9.39 kB 0 B
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.27 kB 0 B
packages/framework/esm-api/dist/openmrs-esm-api.js 9.49 kB 0 B
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 3.24 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.97 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 1.41 kB 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.45 kB 0 B
packages/framework/esm-globals/dist/openmrs-esm-globals.js 1.59 kB 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 35 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 1.47 kB 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19.1 kB 0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js 10.8 kB 0 B
packages/shell/esm-app-shell/dist/7b0b48f40e4e20ca2d36.js 923 B 0 B
packages/shell/esm-app-shell/dist/service-worker.js 51.1 kB +1 B (0%)
packages/tooling/openmrs/dist/cli.js 2.86 kB 0 B
packages/tooling/openmrs/dist/commands/assemble.js 2.32 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 2.26 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 539 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 1.66 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 360 B 0 B
packages/tooling/openmrs/dist/commands/start.js 848 B 0 B
packages/tooling/openmrs/dist/index.js 445 B 0 B
packages/tooling/openmrs/dist/runner.js 799 B 0 B
packages/tooling/openmrs/dist/utils/config.js 639 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 300 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 275 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 2.79 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 370 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 234 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 648 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B 0 B
packages/tooling/webpack-config/dist/index.js 3.01 kB 0 B
packages/tooling/webpack-config/dist/optimize.js 1.79 kB 0 B

compressed-size-action

@ibacher
Copy link
Member

ibacher commented Jan 9, 2023

Surprised this actually has a noticeable size impact!

@ibacher ibacher merged commit 15ce86a into main Jan 9, 2023
@ibacher ibacher deleted the fix/lodash-import branch January 9, 2023 19:41
@denniskigen
Copy link
Member Author

I was not after seeing the bundle size analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskigen @ibacher